Add NODE_NUMBER define #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems good to me. |
|
I get what this is doing, but is it an issue? If implemented, should we also change the timing server display? It shows the node numbering starting at 0. |
|
Being able to specify it as 1-8 makes the Arduino-flashing process easier. |
ethomas997
force-pushed
the
etAddNodeNumDef
branch
from
f244fbd
to
5acb403
Compare
|
Also, just modified the doc to reference the new NODE_NUMBER define. |
ethomas997
force-pushed
the
etAddNodeNumDef
branch
from
5acb403
to
a762e8a
Compare
|
Rebased to master-20181112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a NODE_NUMBER define so node ID can be entered as 1 to 8 value instead of I2C address.
--ET